mirror of
https://github.com/containers/podman
synced 2024-10-19 08:44:11 +00:00
Merge pull request #2670 from giuseppe/runtime-write-rootless-conf-before-reload
rootless: write the custom config file before reload
This commit is contained in:
commit
ea54a1c2f5
|
@ -505,23 +505,32 @@ func newRuntimeFromConfig(userConfigPath string, options ...RuntimeOption) (runt
|
|||
return nil, errors.Wrapf(err, "error configuring runtime")
|
||||
}
|
||||
}
|
||||
if err := makeRuntime(runtime); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
if !foundConfig && rootlessConfigPath != "" {
|
||||
os.MkdirAll(filepath.Dir(rootlessConfigPath), 0755)
|
||||
file, err := os.OpenFile(rootlessConfigPath, os.O_RDWR|os.O_CREATE|os.O_EXCL, 0666)
|
||||
if err != nil && !os.IsExist(err) {
|
||||
return nil, errors.Wrapf(err, "cannot open file %s", rootlessConfigPath)
|
||||
}
|
||||
if err == nil {
|
||||
defer file.Close()
|
||||
enc := toml.NewEncoder(file)
|
||||
if err := enc.Encode(runtime.config); err != nil {
|
||||
os.Remove(rootlessConfigPath)
|
||||
if rootlessConfigPath != "" {
|
||||
// storage.conf
|
||||
storageConfFile := util.StorageConfigFile()
|
||||
if _, err := os.Stat(storageConfFile); os.IsNotExist(err) {
|
||||
if err := util.WriteStorageConfigFile(&runtime.config.StorageConfig, storageConfFile); err != nil {
|
||||
return nil, errors.Wrapf(err, "cannot write config file %s", storageConfFile)
|
||||
}
|
||||
}
|
||||
|
||||
if !foundConfig {
|
||||
os.MkdirAll(filepath.Dir(rootlessConfigPath), 0755)
|
||||
file, err := os.OpenFile(rootlessConfigPath, os.O_RDWR|os.O_CREATE|os.O_EXCL, 0666)
|
||||
if err != nil && !os.IsExist(err) {
|
||||
return nil, errors.Wrapf(err, "cannot open file %s", rootlessConfigPath)
|
||||
}
|
||||
if err == nil {
|
||||
defer file.Close()
|
||||
enc := toml.NewEncoder(file)
|
||||
if err := enc.Encode(runtime.config); err != nil {
|
||||
os.Remove(rootlessConfigPath)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
if err := makeRuntime(runtime); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
return runtime, nil
|
||||
}
|
||||
|
|
|
@ -195,7 +195,7 @@ func GetRootlessRuntimeDir() (string, error) {
|
|||
}
|
||||
}
|
||||
if runtimeDir == "" {
|
||||
tmpDir := filepath.Join(os.TempDir(), fmt.Sprintf("libpod-rundir-%s", uid))
|
||||
tmpDir := filepath.Join(os.TempDir(), fmt.Sprintf("run-%s", uid))
|
||||
os.MkdirAll(tmpDir, 0700)
|
||||
st, err := os.Stat(tmpDir)
|
||||
if err == nil && int(st.Sys().(*syscall.Stat_t).Uid) == os.Geteuid() && st.Mode().Perm() == 0700 {
|
||||
|
@ -311,36 +311,37 @@ func GetDefaultStoreOptions() (storage.StoreOptions, error) {
|
|||
storageOpts = storage.StoreOptions{}
|
||||
storage.ReloadConfigurationFile(storageConf, &storageOpts)
|
||||
}
|
||||
|
||||
if rootless.IsRootless() {
|
||||
if os.IsNotExist(err) {
|
||||
os.MkdirAll(filepath.Dir(storageConf), 0755)
|
||||
file, err := os.OpenFile(storageConf, os.O_RDWR|os.O_CREATE|os.O_EXCL, 0666)
|
||||
if err != nil {
|
||||
return storageOpts, errors.Wrapf(err, "cannot open %s", storageConf)
|
||||
}
|
||||
|
||||
tomlConfiguration := getTomlStorage(&storageOpts)
|
||||
defer file.Close()
|
||||
enc := toml.NewEncoder(file)
|
||||
if err := enc.Encode(tomlConfiguration); err != nil {
|
||||
os.Remove(storageConf)
|
||||
}
|
||||
} else if err == nil {
|
||||
// If the file did not specify a graphroot or runroot,
|
||||
// set sane defaults so we don't try and use root-owned
|
||||
// directories
|
||||
if storageOpts.RunRoot == "" {
|
||||
storageOpts.RunRoot = defaultRootlessRunRoot
|
||||
}
|
||||
if storageOpts.GraphRoot == "" {
|
||||
storageOpts.GraphRoot = defaultRootlessGraphRoot
|
||||
}
|
||||
if rootless.IsRootless() && err == nil {
|
||||
// If the file did not specify a graphroot or runroot,
|
||||
// set sane defaults so we don't try and use root-owned
|
||||
// directories
|
||||
if storageOpts.RunRoot == "" {
|
||||
storageOpts.RunRoot = defaultRootlessRunRoot
|
||||
}
|
||||
if storageOpts.GraphRoot == "" {
|
||||
storageOpts.GraphRoot = defaultRootlessGraphRoot
|
||||
}
|
||||
}
|
||||
return storageOpts, nil
|
||||
}
|
||||
|
||||
// WriteStorageConfigFile writes the configuration to a file
|
||||
func WriteStorageConfigFile(storageOpts *storage.StoreOptions, storageConf string) error {
|
||||
os.MkdirAll(filepath.Dir(storageConf), 0755)
|
||||
file, err := os.OpenFile(storageConf, os.O_RDWR|os.O_CREATE|os.O_EXCL, 0666)
|
||||
if err != nil {
|
||||
return errors.Wrapf(err, "cannot open %s", storageConf)
|
||||
}
|
||||
tomlConfiguration := getTomlStorage(storageOpts)
|
||||
defer file.Close()
|
||||
enc := toml.NewEncoder(file)
|
||||
if err := enc.Encode(tomlConfiguration); err != nil {
|
||||
os.Remove(storageConf)
|
||||
return err
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
// StorageConfigFile returns the path to the storage config file used
|
||||
func StorageConfigFile() string {
|
||||
if rootless.IsRootless() {
|
||||
|
|
Loading…
Reference in a new issue