mirror of
https://github.com/containers/podman
synced 2024-10-19 08:44:11 +00:00
Do not pull if image domain is localhost
With podman play kube, podman would always attempt to pull if the image has the :latest tag. But this would fail if the image was built locally and given latest as the tag. Images build with podman and buildah have localhost as the domain, so check if the domain is localhost. If that is the case, then don't attempt a pull. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
This commit is contained in:
parent
a5ca03915e
commit
b0707af68b
|
@ -15,6 +15,8 @@ Ideally the input file would be one created by Podman (see podman-generate-kube(
|
|||
|
||||
Note: HostPath volume types created by play kube will be given an SELinux private label (Z)
|
||||
|
||||
Note: If the `:latest` tag is used, Podman will attempt to pull the image from a registry. If the image was built locally with Podman or Buildah, it will have `localhost` as the domain, in that case, Podman will use the image from the local store even if it has the `:latest` tag.
|
||||
|
||||
## OPTIONS
|
||||
|
||||
#### **--authfile**=*path*
|
||||
|
|
|
@ -212,8 +212,10 @@ func (ic *ContainerEngine) playKubePod(ctx context.Context, podName string, podY
|
|||
return nil, errors.Wrapf(err, "Failed to parse image %q", container.Image)
|
||||
}
|
||||
// In kube, if the image is tagged with latest, it should always pull
|
||||
// but if the domain is localhost, that means the image was built locally
|
||||
// so do not attempt a pull.
|
||||
if tagged, isTagged := named.(reference.NamedTagged); isTagged {
|
||||
if tagged.Tag() == image.LatestTag {
|
||||
if tagged.Tag() == image.LatestTag && reference.Domain(named) != image.DefaultLocalRegistry {
|
||||
pullPolicy = util.PullImageAlways
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue