From 91baaee9a805e710fde8e4605434d79a20c67f7e Mon Sep 17 00:00:00 2001 From: baude Date: Tue, 29 Oct 2019 12:18:01 -0500 Subject: [PATCH] goland autocorrections just ran the autocorrect code corrections from goland and it found a few nits. Signed-off-by: baude --- cmd/podman/import.go | 2 +- pkg/adapter/containers_remote.go | 2 +- pkg/network/subnet.go | 4 ++-- test/e2e/create_test.go | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cmd/podman/import.go b/cmd/podman/import.go index 027fa72995..5a21e5cc10 100644 --- a/cmd/podman/import.go +++ b/cmd/podman/import.go @@ -6,7 +6,7 @@ import ( "github.com/containers/libpod/cmd/podman/cliconfig" "github.com/containers/libpod/cmd/podman/shared/parse" "github.com/containers/libpod/pkg/adapter" - multierror "github.com/hashicorp/go-multierror" + "github.com/hashicorp/go-multierror" "github.com/pkg/errors" "github.com/spf13/cobra" ) diff --git a/pkg/adapter/containers_remote.go b/pkg/adapter/containers_remote.go index f4e83a9758..20471d8954 100644 --- a/pkg/adapter/containers_remote.go +++ b/pkg/adapter/containers_remote.go @@ -1021,7 +1021,7 @@ func (r *LocalRuntime) Commit(ctx context.Context, c *cliconfig.CommitValues, co func (r *LocalRuntime) ExecContainer(ctx context.Context, cli *cliconfig.ExecValues) (int, error) { var ( oldTermState *term.State - ec int = define.ExecErrorCodeGeneric + ec = define.ExecErrorCodeGeneric ) // default invalid command exit code // Validate given environment variables diff --git a/pkg/network/subnet.go b/pkg/network/subnet.go index 82ab9a8c87..90f0cdfce2 100644 --- a/pkg/network/subnet.go +++ b/pkg/network/subnet.go @@ -18,7 +18,7 @@ func incByte(subnet *net.IPNet, idx int, shift uint) error { subnet.IP[idx] = 0 return incByte(subnet, idx-1, 0) } - subnet.IP[idx] += (1 << shift) + subnet.IP[idx] += 1 << shift return nil } @@ -58,7 +58,7 @@ func LastIPInSubnet(addr *net.IPNet) (net.IP, error) { //nolint:interfacer } hostStart := ones / 8 // Handle the first host byte - cidr.IP[hostStart] |= (0xff & cidr.Mask[hostStart]) + cidr.IP[hostStart] |= 0xff & cidr.Mask[hostStart] // Fill the rest with ones for i := hostStart; i < len(cidr.IP); i++ { cidr.IP[i] = 0xff diff --git a/test/e2e/create_test.go b/test/e2e/create_test.go index 65b747880a..e34146f1a6 100644 --- a/test/e2e/create_test.go +++ b/test/e2e/create_test.go @@ -239,6 +239,6 @@ var _ = Describe("Podman create", func() { session = podmanTest.PodmanNoCache([]string{"create", "--pull", "always", "--name=foo", "nginx"}) session.WaitWithDefaultTimeout() - Expect(session.ExitCode()).To((Equal(0))) + Expect(session.ExitCode()).To(Equal(0)) }) })