Force integration tests to pass

Failing tests are now skipped and we should work from this.

Signed-off-by: Brent Baude <bbaude@redhat.com>

.cirrus.yml

@@ -459,8 +459,6 @@ testing_task:
 # testing matrix.
 integration_test_temporary_task:
 
-    allow_failures: $CI == 'true'
-
     depends_on:
         - "gating"
         - "varlink_api"

test/e2e/attach_test.go

@@ -20,6 +20,7 @@ var _ = Describe("Podman attach", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/build_test.go

@@ -22,6 +22,7 @@ var _ = Describe("Podman build", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/commit_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman commit", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/config.go

@@ -23,4 +23,8 @@ var (
 	// This image has a bogus/invalid seccomp profile which should
 	// yield a json error when being read.
 	alpineBogusSeccomp = "docker.io/libpod/alpine-with-bogus-seccomp:label"
+
+	// v2fail is a temporary variable to help us track
+	// tests that fail in v2
+	v2fail = "does not pass integration tests with v2 podman"
 )

test/e2e/container_inspect_test.go

@@ -17,6 +17,7 @@ var _ = Describe("Podman container inspect", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/containers_conf_test.go

@@ -23,6 +23,7 @@ var _ = Describe("Podman run", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/cp_test.go

@@ -22,6 +22,7 @@ var _ = Describe("Podman cp", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/create_staticip_test.go

@@ -19,6 +19,7 @@ var _ = Describe("Podman create with --ip flag", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		SkipIfRootless()
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {

test/e2e/create_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman create", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/exec_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman exec", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/exists_test.go

@@ -16,6 +16,7 @@ var _ = Describe("Podman image|container exists", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/generate_kube_test.go

@@ -21,6 +21,7 @@ var _ = Describe("Podman generate kube", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/generate_systemd_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman generate systemd", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/healthcheck_run_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman healthcheck run", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/images_test.go

@@ -20,6 +20,7 @@ var _ = Describe("Podman images", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/info_test.go

@@ -16,6 +16,7 @@ var _ = Describe("Podman Info", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/init_test.go

@@ -16,6 +16,7 @@ var _ = Describe("Podman init", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/inspect_test.go

@@ -17,6 +17,7 @@ var _ = Describe("Podman inspect", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/load_test.go

@@ -20,6 +20,7 @@ var _ = Describe("Podman load", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/login_logout_test.go

@@ -32,6 +32,7 @@ var _ = Describe("Podman login and logout", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/network_create_test.go

@@ -76,6 +76,7 @@ var _ = Describe("Podman network create", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		SkipIfRootless()
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {

test/e2e/network_test.go

@@ -34,6 +34,7 @@ var _ = Describe("Podman network", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/pause_test.go

@@ -21,6 +21,7 @@ var _ = Describe("Podman pause", func() {
 	createdState := "Created"
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		SkipIfRootless()
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {

test/e2e/play_kube_test.go

@@ -217,6 +217,7 @@ var _ = Describe("Podman generate kube", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/pod_create_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman pod create", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/pod_infra_container_test.go

@@ -20,6 +20,7 @@ var _ = Describe("Podman pod create", func() {
 
 	BeforeEach(func() {
 		tempdir, err = CreateTempDirInTempDir()
+		Skip(v2fail)
 		if err != nil {
 			os.Exit(1)
 		}

test/e2e/pod_inspect_test.go

@@ -16,6 +16,7 @@ var _ = Describe("Podman pod inspect", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/pod_kill_test.go

@@ -17,6 +17,7 @@ var _ = Describe("Podman pod kill", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/pod_pause_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman pod pause", func() {
 	pausedState := "Paused"
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		SkipIfRootless()
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {

test/e2e/pod_pod_namespaces.go

@@ -19,6 +19,7 @@ var _ = Describe("Podman pod create", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/pod_prune_test.go

@@ -16,6 +16,7 @@ var _ = Describe("Podman pod prune", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/pod_ps_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman ps", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/pod_restart_test.go

@@ -16,6 +16,7 @@ var _ = Describe("Podman pod restart", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/pod_rm_test.go

@@ -19,6 +19,7 @@ var _ = Describe("Podman pod rm", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/pod_start_test.go

@@ -16,6 +16,7 @@ var _ = Describe("Podman pod start", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/pod_stats_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman pod stats", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		cgroupsv2, err := cgroups.IsCgroup2UnifiedMode()
 		Expect(err).To(BeNil())
 

test/e2e/pod_stop_test.go

@@ -16,6 +16,7 @@ var _ = Describe("Podman pod stop", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/pod_top_test.go

@@ -20,6 +20,7 @@ var _ = Describe("Podman top", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/port_test.go

@@ -20,6 +20,7 @@ var _ = Describe("Podman port", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/prune_test.go

@@ -22,6 +22,7 @@ var _ = Describe("Podman prune", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/ps_test.go

@@ -21,6 +21,7 @@ var _ = Describe("Podman ps", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/pull_test.go

@@ -22,6 +22,7 @@ var _ = Describe("Podman pull", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/push_test.go

@@ -22,6 +22,7 @@ var _ = Describe("Podman push", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/restart_test.go

@@ -17,6 +17,7 @@ var _ = Describe("Podman restart", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/rm_test.go

@@ -17,6 +17,7 @@ var _ = Describe("Podman rm", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/rmi_test.go

@@ -17,6 +17,7 @@ var _ = Describe("Podman rmi", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/run_cgroup_parent_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman run with --cgroup-parent", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		SkipIfRootless()
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {

test/e2e/run_device_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman run device", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/run_dns_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman run dns", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/run_entrypoint_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman run entrypoint", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/run_networking_test.go

@@ -19,6 +19,7 @@ var _ = Describe("Podman run networking", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/run_ns_test.go

@@ -19,6 +19,7 @@ var _ = Describe("Podman run ns", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/run_passwd_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman run passwd", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/run_restart_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman run restart containers", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/run_selinux_test.go

@@ -19,6 +19,7 @@ var _ = Describe("Podman run", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/run_signal_test.go

@@ -29,6 +29,7 @@ var _ = Describe("Podman run with --sig-proxy", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tmpdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/run_test.go

@@ -29,6 +29,7 @@ var _ = Describe("Podman run", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/run_userns_test.go

@@ -22,6 +22,7 @@ var _ = Describe("Podman UserNS support", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		if os.Getenv("SKIP_USERNS") != "" {
 			Skip("Skip userns tests.")
 		}

test/e2e/run_volume_test.go

@@ -27,6 +27,7 @@ var _ = Describe("Podman run with volumes", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/runlabel_test.go

@@ -31,6 +31,7 @@ var _ = Describe("podman container runlabel", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/search_test.go

@@ -68,6 +68,7 @@ registries = ['{{.Host}}:{{.Port}}']`
 	registryFileTwoTmpl := template.Must(template.New("registryFileTwo").Parse(regFileContents2))
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/start_test.go

@@ -17,6 +17,7 @@ var _ = Describe("Podman start", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/stats_test.go

@@ -21,6 +21,7 @@ var _ = Describe("Podman stats", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		cgroupsv2, err := cgroups.IsCgroup2UnifiedMode()
 		Expect(err).To(BeNil())
 

test/e2e/stop_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman stop", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/system_df_test.go

@@ -20,6 +20,7 @@ var _ = Describe("podman system df", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/system_reset_test.go

@@ -17,6 +17,7 @@ var _ = Describe("podman system reset", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/systemd_test.go

@@ -23,6 +23,7 @@ var _ = Describe("Podman systemd", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		SkipIfRootless()
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {

test/e2e/trust_test.go

@@ -21,6 +21,7 @@ var _ = Describe("Podman trust", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/untag_test.go

@@ -16,6 +16,7 @@ var _ = Describe("Podman untag", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/version_test.go

@@ -17,6 +17,7 @@ var _ = Describe("Podman version", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/volume_create_test.go

@@ -17,6 +17,7 @@ var _ = Describe("Podman volume create", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/volume_inspect_test.go

@@ -17,6 +17,7 @@ var _ = Describe("Podman volume inspect", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/volume_ls_test.go

@@ -16,6 +16,7 @@ var _ = Describe("Podman volume ls", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/volume_prune_test.go

@@ -18,6 +18,7 @@ var _ = Describe("Podman volume prune", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)

test/e2e/volume_rm_test.go

@@ -16,6 +16,7 @@ var _ = Describe("Podman volume rm", func() {
 	)
 
 	BeforeEach(func() {
+		Skip(v2fail)
 		tempdir, err = CreateTempDirInTempDir()
 		if err != nil {
 			os.Exit(1)