container/podman
container/podman
1
0
Fork 0
mirror of https://github.com/containers/podman synced 2024-10-20 17:23:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3762 from jwhonce/issue/3426

Browse source 
Improve dns-search validation, empty domains now return an error
This commit is contained in:
OpenShift Merge Robot 2019-08-09 20:09:12 +02:00 committed by GitHub
parent dc3816819d f070913c6a
commit 4b91f60e89
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
cmd/podman/shared/create.go
View file

@ -627,6 +627,11 @@ func ParseCreateOpts(ctx context.Context, c *GenericCLIResults, runtime *libpod.
return nil, errors.Errorf("cannot pass additional search domains when also specifying '.'")
}
// Check for explicit dns-search domain of ''
if c.Changed("dns-search") && len(c.StringSlice("dns-search")) == 0 {
return nil, errors.Errorf("'' is not a valid domain")
}
// Validate domains are good
for _, dom := range c.StringSlice("dns-search") {
if dom == "." {