container/podman
container/podman
1
0
Fork 0
mirror of https://github.com/containers/podman synced 2024-10-21 01:34:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Return NamesHistory when returning remote images

Browse source 
We are returning bogus data in podman-remote images --format json.
This change will match the same data returned my podman images --format json.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
This commit is contained in:
Daniel J Walsh 2020-07-29 14:11:10 -04:00
parent 7f38774ee7
commit 23294c9cf6
No known key found for this signature in database
GPG key ID: A2DF901DABE2C028
1 changed files with 1 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
pkg/api/handlers/types.go
View file

@ -203,15 +203,6 @@ func ImageToImageSummary(l *libpodImage.Image) (*entities.ImageSummary, error) {
return nil, errors.Wrapf(err, "Failed to obtain RepoTags for image %s", l.ID())
}
history, err := l.History(context.TODO())
if err != nil {
return nil, errors.Wrapf(err, "Failed to obtain History for image %s", l.ID())
}
historyIds := make([]string, len(history))
for i, h := range history {
historyIds[i] = h.ID
}
digests := make([]string, len(l.Digests()))
for i, d := range l.Digests() {
digests[i] = string(d)
@ -233,7 +224,7 @@ func ImageToImageSummary(l *libpodImage.Image) (*entities.ImageSummary, error) {
Digest: string(l.Digest()),
Digests: digests,
ConfigDigest: string(l.ConfigDigest),
History: historyIds,
History: l.NamesHistory(),
}
return &is, nil
}