container/podman
container/podman
1
0
Fork 0
mirror of https://github.com/containers/podman synced 2024-10-21 17:53:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

The podman start --attach command should not print ID

Browse source 
Somewhere in the Podman v2 rewrite, we allowed
`podman start --attach` to print the container ID of the started
container after exiting from the attach session (via detach key
or the container exiting naturally). We should never print the ID
when `--attach` is given, which makes the fix simple - make the
print statement conditional on `--attach` not being present.

Wierdly, this only happened with `--interactive` was given to
`podman start`. I don't know why that is, but this resolves the
issue without having to dig any deeper, so I'm content.

Fixes #7055

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
This commit is contained in:
Matthew Heon 2020-07-23 11:57:34 -04:00
parent 80add2902c
commit 099649ac1b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cmd/podman/containers/start.go
View file

@ -99,7 +99,7 @@ func start(cmd *cobra.Command, args []string) error {
} }
for _, r := range responses { for _, r := range responses {
if r.Err == nil { if r.Err == nil && !startOptions.Attach {
fmt.Println(r.RawInput) fmt.Println(r.RawInput)
} else { } else {
errs = append(errs, r.Err) errs = append(errs, r.Err)