container/podman
container/podman
1
0
Fork 0
mirror of https://github.com/containers/podman synced 2024-10-21 01:34:37 +00:00
Code Issues Packages Projects Releases Wiki Activity
podman/.golangci.yml

58 lines
936 B
YAML
Raw Normal View History

golangci-lint round #3 this is the third round of preparing to use the golangci-lint on our code base. Signed-off-by: baude <bbaude@redhat.com>
2019-07-11 10:44:12 +00:00
---
run:
concurrency: 6
deadline: 5m
bump golangci-lint to 1.18.0 The latest versions have regressions in --skip-dirs where some linters will still run and error out. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-01-13 11:00:08 +00:00
skip-dirs-use-default: true
golangci-lint round #3 this is the third round of preparing to use the golangci-lint on our code base. Signed-off-by: baude <bbaude@redhat.com>
2019-07-11 10:44:12 +00:00
skip-dirs:
- contrib
make lint: include pkg/tracing Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-01-13 19:06:42 +00:00
- dependencies
golangci-lint round #3 this is the third round of preparing to use the golangci-lint on our code base. Signed-off-by: baude <bbaude@redhat.com>
2019-07-11 10:44:12 +00:00
skip-files:
.golangci.yml: move swagger.go from Makefile Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-01-13 19:13:00 +00:00
- swagger.go
Cirrus: Implement podman automation 2.0 Reimplement CI-automation to remove accumulated technical-debt and optimize workflow. The task-dependency graph designed goal was to shorten it's depth and increase width (i.e. more parallelism). A reduction in redundant building (and 3rd party module download) was also realized by caching `$GOPATH` and `$GOCACHE` early on. This cache is then reused in favor of a fresh clone of the repository (when possible). Note: The system tests typically execute MUCH faster than the integration tests. However, contrary to a fail-fast/fail-early principal, they are executed last. This was implemented due to debug-ability related concerns/preferences of the primary (golang-centric) project developers. Signed-off-by: Chris Evich <cevich@redhat.com>
2020-06-25 21:38:33 +00:00
modules-download-mode: readonly
golangci-lint round #3 this is the third round of preparing to use the golangci-lint on our code base. Signed-off-by: baude <bbaude@redhat.com>
2019-07-11 10:44:12 +00:00
linters:
linter: blacklist linters instead of whitelisting Blacklist linters instead of whitelisting them. This way, we will benefit from new linters when updating and it's easier to actually find and fix open issues. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-01-13 11:03:57 +00:00
enable-all: true
disable:
Cirrus: Implement podman automation 2.0 Reimplement CI-automation to remove accumulated technical-debt and optimize workflow. The task-dependency graph designed goal was to shorten it's depth and increase width (i.e. more parallelism). A reduction in redundant building (and 3rd party module download) was also realized by caching `$GOPATH` and `$GOCACHE` early on. This cache is then reused in favor of a fresh clone of the repository (when possible). Note: The system tests typically execute MUCH faster than the integration tests. However, contrary to a fail-fast/fail-early principal, they are executed last. This was implemented due to debug-ability related concerns/preferences of the primary (golang-centric) project developers. Signed-off-by: Chris Evich <cevich@redhat.com>
2020-06-25 21:38:33 +00:00
# All these break for one reason or another
[NO TESTS NEEDED] Update linter Signed-off-by: Matej Vasek <mvasek@redhat.com>
2021-02-09 18:23:32 +00:00
- nolintlint
- gocognit
- testpackage
- goerr113
- exhaustivestruct
- errorlint
- wrapcheck
- paralleltest
- wsl
- godox
- tparallel
- gomnd
- nlreturn
- noctx
- nestif
- predeclared
- thelper
- ifshort
- staticcheck
- forbidigo
- exhaustive
- unparam
- gofumpt
- gci
- godot
- makezero
linter: blacklist linters instead of whitelisting Blacklist linters instead of whitelisting them. This way, we will benefit from new linters when updating and it's easier to actually find and fix open issues. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-01-13 11:03:57 +00:00
- dupl
- funlen
- gochecknoglobals
- gochecknoinits
- goconst
- gocyclo
- lll
Cirrus: Implement podman automation 2.0 Reimplement CI-automation to remove accumulated technical-debt and optimize workflow. The task-dependency graph designed goal was to shorten it's depth and increase width (i.e. more parallelism). A reduction in redundant building (and 3rd party module download) was also realized by caching `$GOPATH` and `$GOCACHE` early on. This cache is then reused in favor of a fresh clone of the repository (when possible). Note: The system tests typically execute MUCH faster than the integration tests. However, contrary to a fail-fast/fail-early principal, they are executed last. This was implemented due to debug-ability related concerns/preferences of the primary (golang-centric) project developers. Signed-off-by: Chris Evich <cevich@redhat.com>
2020-06-25 21:38:33 +00:00
- unconvert
- errcheck
- gocritic
- gosec
linter: blacklist linters instead of whitelisting Blacklist linters instead of whitelisting them. This way, we will benefit from new linters when updating and it's easier to actually find and fix open issues. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-01-13 11:03:57 +00:00
- maligned
V2 podman system service * Added support for system service * Enabled linting on the varlinkapi source, needed to support V2 service command * Added support for PODMAN_SOCKET Skip linting deprecated code Rather than introduce bugs by correcting deprecated code, linting the code is being skipped. Code that is being ported into V2 is being checked. Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-02 22:58:23 +00:00
linters-settings:
errcheck:
check-blank: false
ignore: encoding/json:^Unmarshal,fmt:.*
Reference in a new issue Copy permalink